Rethrow exceptions from forked threads in bye
#478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See commit `c05ce0eb2c1adb3e29a5a95783f43fa8ed59162e` message. That was motivated by the forked threads in `bye` printing their exceptions to stdout. However, those changes may mask exceptions occuring in `bye` that we actually care about. This commit fixes that by leaving exceptions in `bye` uncaught, and simply rethrowing exceptions that occur in the forked threads of `bye` back to the main thread. No messages printed to stdout, but potentially important exceptions are still propagated.
Closed
|
Obsoleted by #477 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit
c05ce0eb2c1adb3e29a5a95783f43fa8ed59162emessage. That was motivated by the forked threads inbyeprinting their exceptions to stdout. However, those changes may mask exceptions occurring inbyethat we actually care about. This commit fixes that by leaving exceptions inbyeuncaught, and simply rethrowing exceptions that occur in the forked threads ofbyeback to the main thread. No messages printed to stdout, but potentially important exceptions are still propagated.