-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update dwc2_stm32.h #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dwc2_stm32.h #1438
Conversation
Support STM32H7 with only 1 USB port: H72x / H73x / H7Ax / H7Bx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing #endif
// H7 with only 1 USB port: H72x / H73x / H7Ax / H7Bx | ||
// USB_OTG_FS_PERIPH_BASE and OTG_FS_IRQn not defined | ||
#define USB_OTG_FS_PERIPH_BASE USB1_OTG_HS_PERIPH_BASE | ||
#define OTG_FS_IRQn OTG_HS_IRQn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like you miss an #endif, please make sure you compile the example and verify the changes works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is my first PR, and I got confused.
I'm sure it works now.
Add missing #endif
Makes ISO compiler happy
These warning: ..\TinyUSB\src\class\msc\msc_host.c:499: warning: ISO C forbids an empty translation unit [-Wpedantic] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your PR. Sorry for the late response.
Support STM32H7 with only 1 USB port: H72x / H73x / H7Ax / H7Bx
Avoid GCC compiler warnings when -pedantic option is used (strict ISO C)
Describe the PR
The STM32H7 family have 2 sub families:
Add to tusb_options.h
typedef int make_iso_compilers_happy ;
Additional context
Successfully tested on NUCLEO-H723ZG (1 USB) and NUCLEO-H743ZI (2 USB).
fixes #1431