Skip to content

rp2040: make moving 1K of code into RAM optional - and off by default #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

kilograham
Copy link
Collaborator

Made the changes in commit dd035b0 optional because stealing 1K of RAM by default seems undesirable.

It is now controlled by PICO_RP2040_USB_FAST_IRQ which is 0 by default.

It is probably worth documenting what use cases the faster IRQ helps/is-required-for.

@kilograham kilograham requested a review from hathach June 16, 2022 16:08
@kilograham
Copy link
Collaborator Author

cc @liamfraser

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, making it optional is better approach. It was needed when doing usb bit-banging with pio-usb in device mode since the timing is very strict but less so with hw controller.

@hathach hathach merged commit 8012130 into hathach:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants