Skip to content

Add MM32 SDK and USB driver #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Add MM32 SDK and USB driver #869

merged 6 commits into from
Jun 7, 2021

Conversation

zhangslice
Copy link
Contributor

Signed-off-by: zhangslice [email protected]

Describe the PR
A clear and concise description of what this PR solve.

Additional context
If applicable, add any other context about the PR and/or screenshots here.

Signed-off-by: zhangslice <[email protected]>
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hw/mcu should be added as submodule, do mindmotion has github repo for mm322 sdk. else I will help and make one and push update to this PR for you guys.

@zhangslice
Copy link
Contributor Author

zhangslice commented Jun 2, 2021 via email

@hathach
Copy link
Owner

hathach commented Jun 2, 2021

The following repository can be used, and the SDK will be updated if there are any updates or additions https://github.com/zhangslice/mm32sdk

thanks that repo would be useful, I notice that both Keil_core and IAR_Core within the cmsis is the same, without any file differences. you should just have it as CSMSIS/Core https://github.com/zhangslice/mm32sdk/tree/main/mm32f327x/CMSIS

do you want to merge them together ? I am fine If you still want to keep it that way though.

@zhangslice
Copy link
Contributor Author

zhangslice commented Jun 2, 2021 via email

@hathach
Copy link
Owner

hathach commented Jun 2, 2021

Ok thanks for letting me, in general you should not modify those file since they are from ARM which already taken care of the keil/gcc/iar. But that is up to you.

@zhangslice
Copy link
Contributor Author

zhangslice commented Jun 2, 2021 via email

remove the local copy of mm32
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the update to your master branch on your fork, please pull before making any other commit and update. There are 2 requests for change as follows:

  • MIT license is required for dcd_mm32f327x_otg.c
  • tinyusb_keil.zip must be removed

Note: I have to mm32sdk under the company name just in case you guy makes more family than mm32. This could slightly changes the compiling and include path from your project file.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port still need bsp to verify that mcu work with existing project on mm32. However, it is good as intial PR.

Note: I have removed the keil project .zip, such as binary file is not allowed in this repo. You could probably provide it as additional, add-on to your sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants