-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add MM32 SDK and USB driver #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhangslice <[email protected]>
Signed-off-by: zhangslice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hw/mcu should be added as submodule, do mindmotion has github repo for mm322 sdk. else I will help and make one and push update to this PR for you guys.
The following repository can be used, and the SDK will be updated if there are any updates or additions
https://github.com/zhangslice/mm32sdk
…------------------ 原始邮件 ------------------
发件人: "hathach/tinyusb" ***@***.***>;
发送时间: 2021年6月2日(星期三) 中午12:26
***@***.***>;
***@***.******@***.***>;
主题: Re: [hathach/tinyusb] Add MM32 SDK and USB driver (#869)
@hathach commented on this pull request.
the hw/mcu should be added as submodule, do mindmotion has github repo for mm322 sdk. else I will help and make one and push update to this PR for you guys.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
thanks that repo would be useful, I notice that both Keil_core and IAR_Core within the cmsis is the same, without any file differences. you should just have it as do you want to merge them together ? I am fine If you still want to keep it that way though. |
OK, because the syntax of IAR and Keil is different in some places, the reason why they are divided into two folders is that sometimes we will rewrite them, I will delete one of IAR later
------------------ 原始邮件 ------------------
发件人: "hathach/tinyusb" ***@***.***>;
发送时间: 2021年6月2日(星期三) 下午2:14
***@***.***>;
***@***.******@***.***>;
主题: Re: [hathach/tinyusb] Add MM32 SDK and USB driver (#869)
The following repository can be used, and the SDK will be updated if there are any updates or additions https://github.com/zhangslice/mm32sdk
thanks that repo would be useful, I notice that both Keil_core and IAR_Core within the cmsis is the same, without any file differences. you should just have it as CSMSIS/Core https://github.com/zhangslice/mm32sdk/tree/main/mm32f327x/CMSIS
do you want to merge them together ? I am fine If you still want to keep it that way though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Ok thanks for letting me, in general you should not modify those file since they are from ARM which already taken care of the keil/gcc/iar. But that is up to you. |
Well, thank you, that's a good suggestion
…------------------ 原始邮件 ------------------
发件人: "hathach/tinyusb" ***@***.***>;
发送时间: 2021年6月2日(星期三) 下午2:24
***@***.***>;
***@***.******@***.***>;
主题: Re: [hathach/tinyusb] Add MM32 SDK and USB driver (#869)
Ok thanks for letting me, in general you should not modify those file since they are from ARM which already taken care of the keil/gcc/iar. But that is up to you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
remove the local copy of mm32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the update to your master branch on your fork, please pull before making any other commit and update. There are 2 requests for change as follows:
- MIT license is required for
dcd_mm32f327x_otg.c
tinyusb_keil.zip
must be removed
Note: I have to mm32sdk under the company name just in case you guy makes more family than mm32. This could slightly changes the compiling and include path from your project file.
Signed-off-by: zhangslice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port still need bsp to verify that mcu work with existing project on mm32. However, it is good as intial PR.
Note: I have removed the keil project .zip, such as binary file is not allowed in this repo. You could probably provide it as additional, add-on to your sdk.
Signed-off-by: zhangslice [email protected]
Describe the PR
A clear and concise description of what this PR solve.
Additional context
If applicable, add any other context about the PR and/or screenshots here.