Skip to content

gh-253 Shrinkage #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

gh-253 Shrinkage #257

wants to merge 19 commits into from

Conversation

JaimeRZP
Copy link
Contributor

@JaimeRZP JaimeRZP commented Apr 1, 2025

New Features

  • dices.io.py: implements functionality to move fields to components programmatically. We still need an if loop to detect if we are doing Cls and covariances. Maybe this could be streamlined as a for loop for each axis in the result but I don't know how.
  • dices.shrinkage.py: implements the fields-wise methods to compute a Gaussian estimate of the covariance and shrink to it. The shrinkage routines have been streamlined significantly.
  • The jackknife tutorial has been extended to cover shrinkage. See the maths in the markdown for the implementation details.

Known Issues

  • Bug in the analytical covariance computation. It seems like the entries are being overwritten later on.

@JaimeRZP
Copy link
Contributor Author

JaimeRZP commented Apr 8, 2025

pre-commit.ci autofix

@JaimeRZP JaimeRZP requested a review from Copilot April 8, 2025 13:40
@JaimeRZP JaimeRZP requested a review from ntessore April 8, 2025 13:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

heracles/dices/jackknife.py:190

  • The parameter name 'dict' shadows the built-in Python type. Consider renaming it to something like 'samples' or 'spectra_dict'.
def jackknife_covariance(dict, nd=1):

heracles/dices/jackknife.py:235

  • The variable 'a' is used before it is defined. Please check and replace 'a' with the intended variable (likely the array being processed).
    if (a1, b1) == ("POS", "POS"):
                a = np.expand_dims(a, axis=0)

heracles/dices/jackknife.py:237

  • The variable 'a' is used before it is defined. Please verify the correct variable to modify and update accordingly.
    if (a2, b2) == ("POS", "POS"):
                a = np.expand_dims(a, axis=1)

@JaimeRZP
Copy link
Contributor Author

JaimeRZP commented Apr 8, 2025

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant