-
Notifications
You must be signed in to change notification settings - Fork 1
gh-253 Shrinkage #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaimeRZP
wants to merge
19
commits into
main
Choose a base branch
from
253-shrinkage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gh-253 Shrinkage #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
heracles/dices/jackknife.py:190
- The parameter name 'dict' shadows the built-in Python type. Consider renaming it to something like 'samples' or 'spectra_dict'.
def jackknife_covariance(dict, nd=1):
heracles/dices/jackknife.py:235
- The variable 'a' is used before it is defined. Please check and replace 'a' with the intended variable (likely the array being processed).
if (a1, b1) == ("POS", "POS"):
a = np.expand_dims(a, axis=0)
heracles/dices/jackknife.py:237
- The variable 'a' is used before it is defined. Please verify the correct variable to modify and update accordingly.
if (a2, b2) == ("POS", "POS"):
a = np.expand_dims(a, axis=1)
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
dices.io.py
: implements functionality to move fields to components programmatically. We still need an if loop to detect if we are doing Cls and covariances. Maybe this could be streamlined as a for loop for each axis in the result but I don't know how.dices.shrinkage.py
: implements the fields-wise methods to compute a Gaussian estimate of the covariance and shrink to it. The shrinkage routines have been streamlined significantly.Known Issues