change the approach to obtaining user statistics data #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtm9
requested changes
Jul 2, 2025
| end | ||
|
|
||
| defp calculate_stats(user_games) do | ||
| total_games = length(user_games) |
There was a problem hiding this comment.
let's get all these count in SQL query
| stats = calculate_stats(user_games) | ||
|
|
||
| case Repo.get_by(UserGameStatistics, user_id: user_id) do | ||
| nil -> |
There was a problem hiding this comment.
let' write insert on conflict (user_id) update
| field :total_losses, :integer | ||
| field :total_giveups, :integer, default: 0 | ||
| field :versus_bot_games, :integer | ||
| field :versus_human_games, :integer |
There was a problem hiding this comment.
do we need versus_bot_games and versus_human_games?
| @@ -332,6 +332,10 @@ defmodule Codebattle.Game.Engine do | |||
| }) | |||
|
|
|||
| update_user!(player) | |||
|
|
|||
| unless player.is_bot or player.is_guest do | |||
| Codebattle.UserGameStatistics.Context.update_user_stats(player.id) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2182