HHH-18588 fix minor defects in Hibernate Introduction article #8912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
commented
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
NathanQingyangXu
changed the title
NathanQingyangXu
changed the title
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
NathanQingyangXu
changed the title
gavinking
requested changes
Sep 10, 2024
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
NathanQingyangXu
force-pushed
the
HHH-18588-new
branch
from
45f4a3e to
abe3a85
Compare
|
@gavinking , I finished checking the whole doc. I learned a lot during the process. Thanks for the brillant and insightful documentation! |
NathanQingyangXu
force-pushed
the
HHH-18588-new
branch
from
abe3a85 to
c4a60fb
Compare
|
I also created a similar PR for Hibernate Query Language doc at #8941 |
NathanQingyangXu
referenced
this pull request
Oct 2, 2024
* HHH-18605 fix some minor defects in Hibernate Query Language doc Co-authored-by: nathan.xu <[email protected]>
gavinking
reviewed
Oct 3, 2024
gavinking
requested changes
Oct 3, 2024
Co-authored-by: Gavin King <[email protected]>
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
requested changes
Oct 4, 2024
gavinking
approved these changes
Oct 5, 2024
|
Thanks, @NathanQingyangXu ! |
|
Ugh, I should have squashed this. I did not notice it was spread over multiple commits. Oops. |
|
You might well revert commits already pushed. E.g. as per
https://gist.github.com/gunjanpatel/18f9e4d1eb609597c50c2118e416e6a6
…On Sat, Oct 5, 2024, 2:54 a.m. Gavin King ***@***.***> wrote:
Ugh, I should have squashed this. I did not notice it was spread over
multiple commits. Oops.
—
Reply to this email directly, view it on GitHub
<#8912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6UYATDJZA374WEH3LKWT3ZZ6EJDAVCNFSM6AAAAABN4UBH2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUHE2TKMJUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18588
Fixed some minor defects.