HHH-19188 Remove LGPL-only contributions - Batch 10 #9799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
fix/HHH-19188-Remove-LGPL-only-contributions---Batch-10
branch
2 times, most recently
from
63582b7 to
a324556
Compare
|
@marko-bekhta We do not need to remove e45e1cf because the author emailed us his consent. |
|
oook 😃, |
No idea, you're the author of that commit. |
fair point 😄, I did that to somewhat replace the one you mentioned that we can keep and as a bonus to keep it more consistent between the two impls. In other words, once I revert e45e1cf do you think my change is worth keeping, or the original impl is more easier to read/maintain and I should drop the change? |
I mean, hard to tell from the diff. Does it reduce the amount of code? |
marko-bekhta
force-pushed
the
fix/HHH-19188-Remove-LGPL-only-contributions---Batch-10
branch
from
a324556 to
2fab075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19188
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19183