fix: 18844: HDHM repair mechanism should not be enabled for snapshots (#18859)

Fixes: #18844
Reviewed-by: Anthony Petrov <[email protected]>, Ivan Malygin <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>

Author: artemananiev

platform-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/MerkleDb.java

@@ -443,7 +443,7 @@ private MerkleDbDataSource getDataSource(
             final int tableId,
             final String tableName,
             final boolean dbCompactionEnabled,
-            final boolean useDiskIndices)
+            final boolean offlineUse)
             throws IOException {
         final MerkleDbTableConfig tableConfig = getTableConfig(tableId);
         if (tableConfig == null) {
@@ -456,7 +456,7 @@ private MerkleDbDataSource getDataSource(
             }
             try {
                 return new MerkleDbDataSource(
-                        this, config, tableName, tableId, tableConfig, dbCompactionEnabled, useDiskIndices);
+                        this, config, tableName, tableId, tableConfig, dbCompactionEnabled, offlineUse);
             } catch (final IOException z) {
                 rethrowIO.set(z);
                 return null;

platform-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/MerkleDbDataSource.java

@@ -176,13 +176,13 @@ public MerkleDbDataSource(
             final int tableId,
             final MerkleDbTableConfig tableConfig,
             final boolean compactionEnabled,
-            final boolean preferDiskBasedIndices)
+            final boolean offlineUse)
             throws IOException {
         this.database = database;
         this.tableName = tableName;
         this.tableId = tableId;
         this.tableConfig = tableConfig;
-        this.preferDiskBasedIndices = preferDiskBasedIndices;
+        this.preferDiskBasedIndices = offlineUse;
 
         final MerkleDbConfig merkleDbConfig = config.getConfigData(MerkleDbConfig.class);
 
@@ -348,11 +348,14 @@ public MerkleDbDataSource(
                 tableName + ":objectKeyToPath",
                 preferDiskBasedIndices);
         keyToPath.printStats();
-        final String tablesToRepairHdhmConfig = merkleDbConfig.tablesToRepairHdhm();
-        if (tablesToRepairHdhmConfig != null) {
-            final String[] tableNames = tablesToRepairHdhmConfig.split(",");
-            if (Arrays.stream(tableNames).filter(s -> !s.isBlank()).anyMatch(tableName::equals)) {
-                keyToPath.repair(getFirstLeafPath(), getLastLeafPath(), pathToKeyValue);
+        // Repair keyToPath based on pathToKeyValue data, if requested and not offlineUse
+        if (!offlineUse) {
+            final String tablesToRepairHdhmConfig = merkleDbConfig.tablesToRepairHdhm();
+            if (tablesToRepairHdhmConfig != null) {
+                final String[] tableNames = tablesToRepairHdhmConfig.split(",");
+                if (Arrays.stream(tableNames).filter(s -> !s.isBlank()).anyMatch(tableName::equals)) {
+                    keyToPath.repair(getFirstLeafPath(), getLastLeafPath(), pathToKeyValue);
+                }
             }
         }