Skip to content

HDHM repair mechanism should not be enabled for snapshots #18844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artemananiev opened this issue Apr 15, 2025 · 0 comments · Fixed by #18859
Closed

HDHM repair mechanism should not be enabled for snapshots #18844

artemananiev opened this issue Apr 15, 2025 · 0 comments · Fixed by #18859
Assignees
@artemananiev
Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node.
Milestone
v0.62

Comments

@artemananiev
Copy link
Contributor

This is a follow-up for #18593. That fix introduced a mechanism to repair HDHM (index and data) for certain tables. The mechanism includes HDHM.rebuild() method, which is called from MerkleDbDataSource constructor, if the table is listed in the config. The issue here is the constructor is called not only when a state is loaded at node startup, but also on every state snapshot. No need to rebuild HDHM when taking snapshots, it's just a waste of resources and it makes snapshots longer than needed.
@artemananiev artemananiev added Performance Issues related to performance concerns. Platform Tickets pertaining to the platform Platform Data Structures Platform Virtual Map Stability Tickets pertaining to the stability of the consensus node. labels Apr 15, 2025
@artemananiev artemananiev added this to the v0.62 milestone Apr 15, 2025
@artemananiev artemananiev self-assigned this Apr 15, 2025
@artemananiev artemananiev moved this to 🛠 In Progress in Foundation Team Apr 15, 2025
@artemananiev artemananiev changed the title HDHM rebuild mechanism should not be enabled for snapshots HDHM repair mechanism should not be enabled for snapshots Apr 15, 2025
@artemananiev artemananiev moved this from 🛠 In Progress to 👀 In Review in Foundation Team Apr 15, 2025
@artemananiev artemananiev mentioned this issue Apr 15, 2025
Merged
@artemananiev artemananiev moved this from 👀 In Review to ✅ Done in Foundation Team Apr 15, 2025
artemananiev added a commit that referenced this issue Apr 15, 2025
@artemananiev
Included changes for #18844
bc004eb 
Signed-off-by: Artem Ananev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemananiev artemananiev

Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node.
Projects
Foundation Team
Status: ✅ Done
Milestone
v0.62
1 participant
@artemananiev