fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. #12262

imalygin · 2024-03-20T22:04:46Z

Description:

Enabled logging exceptions processed by StandardWorkGroup into System.err. This should help with the tests failure investigations. Before this change the exceptions were just not logged at all in the testing context.

Misc: Re-enabled tests in VirtualMapLargeReconnectTest

Related issue(s):

Related to #11507

Notes for reviewer:

This change is not supposed to affect production code in any way. It was added for testing purposes only.

...dk/swirlds-benchmarks/src/jmh/java/com/swirlds/benchmark/reconnect/MerkleBenchmarkUtils.java

...rm-sdk/swirlds-common/src/main/java/com/swirlds/common/threading/pool/StandardWorkGroup.java

github-actions · 2024-03-20T22:30:49Z

Node: HAPI Test (Restart) Results

2 tests 2 ✅ 5m 35s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T22:33:40Z

Node: HAPI Test (Node Death Reconnect) Results

1 tests 1 ✅ 24s ⏱️
1 suites 0 💤
2 files 0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T22:49:51Z

Node: HAPI Test (Token) Results

209 tests 209 ✅ 20m 56s ⏱️
16 suites 0 💤
16 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T22:58:15Z

Node: HAPI Test (Crypto) Results

316 tests 316 ✅ 42m 13s ⏱️
25 suites 0 💤
25 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T23:09:08Z

Node: HAPI Test (Misc) Results

433 tests 423 ✅ 40m 48s ⏱️
75 suites 10 💤
75 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T23:19:32Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✅ 54m 21s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-21T00:48:24Z

Node: HAPI Test (Smart Contract) Results

555 tests 555 ✅ 1h 4m 25s ⏱️
61 suites 0 💤
61 files 0 ❌

Results for commit ef7da71.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-21T01:10:33Z

Node: Unit Test Results

2 280 files ±0 2 280 suites ±0 3h 24m 51s ⏱️ + 42m 25s
112 308 tests ±0 112 239 ✅ ±0 69 💤 ±0 0 ❌ ±0
120 794 runs ±0 120 725 ✅ ±0 69 💤 ±0 0 ❌ ±0

Results for commit ef7da71. ± Comparison against base commit 653f57f.

This pull request removes 3979 and adds 3744 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=11181,hostnameExternal=187.215.21.132,portExternalIpv4=27928,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@20ca15f4,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@408b0977,memo=UVrxFBI2b4],
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d49d5b4d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7cda77fa
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8371ef11
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8265c933
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@cdabf1c5
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@998c4dfc
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@238d595b
…

♻️ This comment has been updated with latest results.

…System.err. Misc: Re-enabled tests in VirtualMapLargeReconnectTest Signed-off-by: Ivan Malygin <[email protected]>

Signed-off-by: Ivan Malygin <[email protected]>

…le to override in tests. Signed-off-by: Ivan Malygin <[email protected]>

Signed-off-by: Ivan Malygin <[email protected]>

...mmon/src/testFixtures/java/com/swirlds/common/test/fixtures/merkle/util/MerkleTestUtils.java

Signed-off-by: Ivan Malygin <[email protected]>

imalygin requested review from a team as code owners March 20, 2024 22:04

imalygin requested review from artemananiev, OlegMazurov, litt3 and timo0 March 20, 2024 22:04

imalygin force-pushed the 11507-better-test-logging branch from ddd2f1a to 82939c0 Compare March 20, 2024 22:09

artemananiev reviewed Mar 20, 2024

View reviewed changes

...dk/swirlds-benchmarks/src/jmh/java/com/swirlds/benchmark/reconnect/MerkleBenchmarkUtils.java Outdated Show resolved Hide resolved

artemananiev reviewed Mar 20, 2024

View reviewed changes

...rm-sdk/swirlds-common/src/main/java/com/swirlds/common/threading/pool/StandardWorkGroup.java Show resolved Hide resolved

artemananiev previously approved these changes Mar 20, 2024

View reviewed changes

imalygin changed the title ~~11507 Enabled logging exceptions processed by StandardWorkGroup into System.err.~~ fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. Mar 20, 2024

imalygin force-pushed the 11507-better-test-logging branch 2 times, most recently from 8de4f67 to 309aec5 Compare March 21, 2024 13:51

imalygin dismissed artemananiev’s stale review via 110bb03 March 21, 2024 20:00

imalygin force-pushed the 11507-better-test-logging branch from 110bb03 to 9222d21 Compare March 21, 2024 20:38

imalygin added 4 commits April 11, 2024 17:26

11507 Enabled logging exceptions processed by StandardWorkGroup into …

637a6cb

…System.err. Misc: Re-enabled tests in VirtualMapLargeReconnectTest Signed-off-by: Ivan Malygin <[email protected]>

Addressed PR comments.

e4b932a

Signed-off-by: Ivan Malygin <[email protected]>

Extracted creation of StandardWorkGroup to a separate method to be ab…

d70bdd9

…le to override in tests. Signed-off-by: Ivan Malygin <[email protected]>

Increased asyncStreamTimeout to 20s in VirtualMapReconnectTestBase

5182609

Signed-off-by: Ivan Malygin <[email protected]>

imalygin force-pushed the 11507-better-test-logging branch from 9222d21 to 5182609 Compare April 11, 2024 21:30

anthony-swirldslabs previously approved these changes Apr 11, 2024

View reviewed changes

artemananiev reviewed Apr 11, 2024

View reviewed changes

...mmon/src/testFixtures/java/com/swirlds/common/test/fixtures/merkle/util/MerkleTestUtils.java Outdated Show resolved Hide resolved

Addressed review comment.

ef7da71

Signed-off-by: Ivan Malygin <[email protected]>

imalygin dismissed anthony-swirldslabs’s stale review via ef7da71 April 11, 2024 23:10

imalygin requested review from anthony-swirldslabs and artemananiev April 11, 2024 23:11

anthony-swirldslabs approved these changes Apr 11, 2024

View reviewed changes

artemananiev approved these changes Apr 11, 2024

View reviewed changes

imalygin merged commit 95ea39f into develop Apr 12, 2024

imalygin deleted the 11507-better-test-logging branch April 12, 2024 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. #12262

fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. #12262

Uh oh!

imalygin commented Mar 20, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 21, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. #12262

fix: 11507 Enabled logging exceptions processed by StandardWorkGroup into System.err. #12262

Uh oh!

Conversation

imalygin commented Mar 20, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Restart) Results

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Node Death Reconnect) Results

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Token) Results

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Crypto) Results

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Misc) Results

Uh oh!

github-actions bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Time Consuming) Results

Uh oh!

github-actions bot commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: HAPI Test (Smart Contract) Results

Uh oh!

github-actions bot commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Node: Unit Test Results

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 21, 2024 •

edited

Loading

github-actions bot commented Mar 21, 2024 •

edited

Loading