fix: 18571: Current path range should be respected when path to hash and path to KV indices are restored #18592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and path to KV indices are restored Signed-off-by: Artem Ananev <[email protected]>
artemananiev
added
Platform Virtual Map
Platform Data Structures
Platform
artemananiev
requested review from
imalygin,
thenswan,
OlegMazurov and
anthony-swirldslabs
imalygin
reviewed
Apr 1, 2025
platform-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/MerkleDbDataSource.java
Show resolved
Hide resolved
imalygin
reviewed
Apr 1, 2025
...k/swirlds-merkledb/src/timingSensitive/java/com/swirlds/merkledb/MerkleDbDataSourceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Artem Ananev <[email protected]>
anthony-swirldslabs
approved these changes
Apr 1, 2025
...k/swirlds-merkledb/src/timingSensitive/java/com/swirlds/merkledb/MerkleDbDataSourceTest.java
Show resolved
Hide resolved
platform-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/MerkleDbDataSource.java
Show resolved
Hide resolved
imalygin
approved these changes
Apr 1, 2025
netopyr
added a commit
that referenced
this pull request
Apr 2, 2025
* main: chore: prepare consensus event creator (#18585) fix: airdrop TCK issues fixes (#18582) feat: Long Term Schedule Transaction Support For DAB transactions (#18539) test: Add Ingest workflow checks HAPI tests (#18382) fix: 18571: Current path range should be respected when path to hash and path to KV indices are restored (#18592) chore: upgrade PBJ to v0.10.3 (#18597) chore: update new git-semver version (#18596) chore: 13214 custom fee assessor v3 (#18503) Signed-off-by: Michael Heinrichs <[email protected]>
netopyr
added a commit
that referenced
this pull request
Apr 7, 2025
* main: chore: prepare consensus event creator (#18585) fix: airdrop TCK issues fixes (#18582) feat: Long Term Schedule Transaction Support For DAB transactions (#18539) test: Add Ingest workflow checks HAPI tests (#18382) fix: 18571: Current path range should be respected when path to hash and path to KV indices are restored (#18592) chore: upgrade PBJ to v0.10.3 (#18597) chore: update new git-semver version (#18596) chore: 13214 custom fee assessor v3 (#18503) # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/module-info.java
This was referenced Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary:
When a MerkleDb data source instance is created from existing data files, and path to hash / path to KV indices are restored, leaf path range is taken into consideration. Old data files may contain entries outside the current path range, now these entries are ignored
Testing: there is an existing test to check that MerkleDb indices can be restored from data files. This test is improved, so it checks multiple different path ranges, not just one
Fixes: #18571
Signed-off-by: Artem Ananev [email protected]