-
Notifications
You must be signed in to change notification settings - Fork 153
feat: Use existing key to create an account #18611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Neeharika-Sompalli
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mhess-swl
netopyr
added a commit
that referenced
this pull request
Apr 9, 2025
* main: chore: Moved EventCreation and TransactionPool classes to event-creator module (#18740) chore: 12987 improve token and staking unit test coverage (#18531) chore: remove some obsolete feature flags (#18639) chore: Make the check for slack user ID case insensitive (#18739) feat: Handle `BlockAcknowledgements` received from Block Nodes (#18536) chore: Lazy initialize `SNARK_KEYS` (#18709) feat: 18593: Need a mechanism to repair key to path mapping from data files at startup (#18625) chore: remove some obsolete feature flags pt2 (#18641) fix: 1280 hip 1056 block item with failed contract create result contains a contract (#18728) chore: set blockPeriod to 2 sec (#18707) test: Add tests to cover missing test scenarios from TCK (#18667) feat: Jumbo bytes throttle (#18389) chore: prepare consensus-utility for event-creator-module (#18695) chore: Add missing dependencies (#18724) chore: remove obsolete feature flags pt3 (#18643) feat: Use existing key to create an account (#18611) ci: add 'needs' to HAPI Tests (ISS) (#18556)
joshmarinacci
pushed a commit
to joshmarinacci/hiero-consensus-node
that referenced
this pull request
Apr 10, 2025
Signed-off-by: Matt Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for creating a new account with an existing key file and pass file. The existing key may be of type ed25519 or secp256k1 (without the need to specify the key type). The documentation has been updated to reflect this new feature, and new key generation with a new account should work as before.