Skip to content

feat: Use existing key to create an account #18611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

mhess-swl
Copy link
Contributor

Adds support for creating a new account with an existing key file and pass file. The existing key may be of type ed25519 or secp256k1 (without the need to specify the key type). The documentation has been updated to reflect this new feature, and new key generation with a new account should work as before.

@mhess-swl mhess-swl added this to the v0.62 milestone Apr 2, 2025
@mhess-swl mhess-swl self-assigned this Apr 2, 2025
@mhess-swl mhess-swl requested review from a team and bubo April 2, 2025 15:56
@mhess-swl mhess-swl requested review from a team as code owners April 4, 2025 13:59
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mhess-swl

@mhess-swl mhess-swl merged commit a53322d into main Apr 7, 2025
49 checks passed
@mhess-swl mhess-swl deleted the 18609-use-existing-key-account-create branch April 7, 2025 21:37
netopyr added a commit that referenced this pull request Apr 9, 2025
* main:
  chore: Moved EventCreation and TransactionPool classes to event-creator module (#18740)
  chore: 12987 improve token and staking unit test coverage (#18531)
  chore: remove some obsolete feature flags (#18639)
  chore: Make the check for slack user ID case insensitive (#18739)
  feat: Handle `BlockAcknowledgements` received from Block Nodes (#18536)
  chore: Lazy initialize `SNARK_KEYS` (#18709)
  feat: 18593: Need a mechanism to repair key to path mapping from data files at startup (#18625)
  chore: remove some obsolete feature flags pt2 (#18641)
  fix: 1280 hip 1056 block item with failed contract create result contains a contract (#18728)
  chore: set blockPeriod to 2 sec (#18707)
  test: Add tests to cover missing test scenarios from TCK (#18667)
  feat: Jumbo bytes throttle (#18389)
  chore: prepare consensus-utility for event-creator-module (#18695)
  chore: Add missing dependencies (#18724)
  chore: remove obsolete feature flags pt3 (#18643)
  feat: Use existing key to create an account (#18611)
  ci: add 'needs' to HAPI Tests (ISS) (#18556)
joshmarinacci pushed a commit to joshmarinacci/hiero-consensus-node that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants