-
Notifications
You must be signed in to change notification settings - Fork 153
chore: Add metrics for active node percentage #18655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
mhess-swl
previously approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had some cosmetic changes that can be done later. Ty @Neeharika-Sompalli!
hedera-node/hedera-app/src/main/java/com/hedera/node/app/metrics/NodeMetrics.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/metrics/NodeMetrics.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/services/NodeRewardManager.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/services/NodeRewardManager.java
Show resolved
Hide resolved
…cs/NodeMetrics.java Co-authored-by: Matt Hess <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]>
…ces/NodeRewardManager.java Co-authored-by: Matt Hess <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
mhess-swl
previously approved these changes
Apr 3, 2025
Signed-off-by: Neeharika-Sompalli <[email protected]>
mhess-swl
previously approved these changes
Apr 4, 2025
Signed-off-by: Neeharika-Sompalli <[email protected]>
mhess-swl
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18587
Adds metrics for average of nodeActivePercent and snapshot of activePercent each day