chore: minor changes in AddressBook to support planned move #18933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Text() Signed-off-by: Michael Heinrichs <[email protected]>
|
@netopyr should we focus on removing address book rather than moving it? |
No. Removing the address book is a huge task that will take quite some time while blocking modularization. Moving the address book to a different module can be done quickly. |
lpetrovic05
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces some small changes that will make the planned move of
AddressandAddressBookto theconsensus-modelmodule simpler.AddressBookIteratoris now an inner class ofAddressBook. This is a pretty common approach for collections. The iterator was not referenced anywhere else this avoids aninternalpackage with a single class.AddressBookUtilsanyway.Related issue(s):
Part of #18927