Add optional path for blocklist config #8326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <[email protected]>
MiroslavGatsanoga
requested review from
Neeharika-Sompalli,
povolev15,
Nana-EC and
natanasow
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Nana-EC
previously approved these changes
Sep 1, 2023
2 tasks
povolev15
previously approved these changes
Sep 5, 2023
...main/java/com/hedera/node/app/service/mono/state/initialization/BlocklistAccountCreator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/mono/state/initialization/BlocklistAccountCreator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
jeromy-cannon
previously approved these changes
Sep 25, 2023
hedera-node/hedera-mono-service/src/test/resources/bootstrap/standard.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8326 +/- ##
=============================================
- Coverage 65.27% 65.27% -0.01%
Complexity 29207 29207
=============================================
Files 3218 3219 +1
Lines 122314 122332 +18
Branches 12512 12514 +2
=============================================
+ Hits 79845 79856 +11
- Misses 39520 39525 +5
- Partials 2949 2951 +2
☔ View full report in Codecov by Sentry. |
iwsimon
reviewed
Sep 27, 2023
...main/java/com/hedera/node/app/service/mono/state/initialization/BlocklistAccountCreator.java
Outdated
Show resolved
Hide resolved
jsync-swirlds
previously approved these changes
Sep 27, 2023
Signed-off-by: Miroslav Gatsanoga <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
jsync-swirlds
approved these changes
Sep 27, 2023
jeromy-cannon
approved these changes
Sep 27, 2023
Nana-EC
approved these changes
Sep 28, 2023
Neeharika-Sompalli
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently the blocklist is defined in as resource and if we want to update the definition we will need to rebuild in order for the changes to take effect. That means local node is not able to use a blocklist definition different than the one defined under
src/main/resources/evm-addresses-blocklist.csv.This PR adds the ability to read the blocklist file specified by
accounts.blocklist.path(renaming of the previousaccounts.blocklist.resource) from some path e.g.data/onboard/evm-addresses-blocklist.csv. In order to achieve that thebootstrap.propertieswould need to contain the following two lines:If the path does not correspond to an existing file or it's left empty then we'll fallback and load the default
src/main/resources/evm-addresses-blocklist.csv. An example config that would load the default resource would be:Related issues:
Checklist