Skip to content

chore: add eth_getBlockReceipts method to OpenRPC definitions (#3793) #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mwb-al
Copy link
Contributor

@mwb-al mwb-al commented May 26, 2025

Description:

Added eth_getBlockReceipts to openrpc.json to reflect the method already implemented in the application.

Related issue(s):

Fixes #3793

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mwb-al mwb-al requested review from a team as code owners May 26, 2025 09:43
@mwb-al mwb-al requested a review from acuarica May 26, 2025 09:43
@lfdt-bot
Copy link

lfdt-bot commented May 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@mwb-al mwb-al marked this pull request as draft May 26, 2025 10:34
@mwb-al mwb-al changed the title chore: add eth_getBlockReceipts method to OpenRPC definitions (#1837) chore: add eth_getBlockReceipts method to OpenRPC definitions (#3793) May 26, 2025
@mwb-al mwb-al marked this pull request as ready for review May 26, 2025 10:53
@arianejasuwienas arianejasuwienas added the documentation Improvements or additions to documentation label May 26, 2025
@mwb-al
Copy link
Contributor Author

mwb-al commented May 26, 2025

->blobGasUsed

blobGasUsed comes from the Ethereum spec (https://github.com/ethereum/execution-apis/), but Hedera doesn't support blob transactions (EIP-4844).
Should we keep this field for consistency, or remove it?

@mwb-al
Copy link
Contributor Author

mwb-al commented May 28, 2025

blobGasUsed and blobGasPrice fields have been removed. These fields are not used (ITransactionReceipt)

@mwb-al mwb-al marked this pull request as draft May 30, 2025 07:59
@mwb-al mwb-al marked this pull request as ready for review June 3, 2025 09:36
Ferparishuertas
Ferparishuertas previously approved these changes Jun 3, 2025
Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acuarica
acuarica previously approved these changes Jun 4, 2025
@mwb-al mwb-al marked this pull request as draft June 4, 2025 07:53
@quiet-node quiet-node added this to the 0.69.0 milestone Jun 9, 2025
@natanasow natanasow modified the milestones: 0.69.0, 0.70.0 Jun 13, 2025
@acuarica
Copy link
Contributor

Is this PR still draft? Otherwise, we should mark it as "Ready for review" for better visibility.

@mwb-al mwb-al dismissed stale reviews from acuarica and Ferparishuertas via 2399791 June 26, 2025 15:06
@mwb-al
Copy link
Contributor Author

mwb-al commented Jun 26, 2025

I added a case here where 'to' is null – which is compliant with the Ethereum spec.

As soon as this is merged:
#3825
I'll switch this PR from Draft to Ready for Review.

@mwb-al mwb-al marked this pull request as ready for review July 1, 2025 12:09
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage        ?   39.28%           
=======================================
  Files           ?       83           
  Lines           ?     4816           
  Branches        ?      988           
=======================================
  Hits            ?     1892           
  Misses          ?     2665           
  Partials        ?      259           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing eth_getBlockReceipts to openrpc.json
8 participants