Skip to content

feat: make blockNumberOrTagOrHash a required parameter for eth_getStorageAt (#3839) #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mwb-al
Copy link
Contributor

@mwb-al mwb-al commented Jun 25, 2025

Description:

This PR updates the eth_getStorageAt method to require the blockNumberOrTagOrHash parameter, aligning it with the Ethereum OpenRPC specification. It also adjusts validation rules, method signature, and tests to enforce this requirement.

Related issue(s):

Fixes #3839

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas dismissed their stale review June 26, 2025 08:06

Let's collect two other approvals anyway.

@Ferparishuertas Ferparishuertas self-requested a review June 30, 2025 11:41
Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arianejasuwienas arianejasuwienas added the ArianeLabs Items ArianeLabs is contributing to label Jul 1, 2025
@arianejasuwienas arianejasuwienas self-assigned this Jul 1, 2025
@arianejasuwienas arianejasuwienas added this to the 0.70.0 milestone Jul 1, 2025
@arianejasuwienas arianejasuwienas merged commit e7975bf into hiero-ledger:main Jul 1, 2025
39 of 41 checks passed
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage        ?   45.71%           
=======================================
  Files           ?       83           
  Lines           ?     4819           
  Branches        ?      988           
=======================================
  Hits            ?     2203           
  Misses          ?     2280           
  Partials        ?      336           
Files with missing lines Coverage Δ
...ckages/relay/src/lib/decorators/cache.decorator.ts 69.81% <ø> (ø)
packages/relay/src/lib/eth.ts 52.66% <ø> (ø)
...ices/ethService/contractService/ContractService.ts 25.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArianeLabs Items ArianeLabs is contributing to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align eth_getStorageAt parameter validation with Ethereum's OpenRPC specification
4 participants