Skip to content

feat: add a start-up check for minimum node and npm versions #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

natanasow
Copy link
Contributor

Description:

Currently, the user is not warned if their node/npm version is outdated and doesn't meet the minimum requirements.

Solution:

Add a start-up check for the node/npm version.

Related issue(s):

Fixes #863

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow self-assigned this Nov 25, 2024
@natanasow natanasow marked this pull request as ready for review November 25, 2024 11:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.38%. Comparing base (2f9cc8c) to head (b3550ac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/state/InitState.ts 25.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   62.89%   62.38%   -0.52%     
==========================================
  Files          30       30              
  Lines        1237     1252      +15     
  Branches      149      152       +3     
==========================================
+ Hits          778      781       +3     
- Misses        438      450      +12     
  Partials       21       21              
Files with missing lines Coverage Δ
src/state/InitState.ts 84.74% <25.00%> (-9.43%) ⬇️

Impacted file tree graph

---- 🚨 Try these New Features:

Signed-off-by: nikolay <[email protected]>
Copy link

@natanasow natanasow merged commit 8f70b8e into main Nov 27, 2024
14 checks passed
@natanasow natanasow deleted the 863-add-a-startup-check-for-min-node-and-npm-versions branch November 27, 2024 09:46
@isavov
Copy link
Member

isavov commented Nov 27, 2024

Nice! That one was long overdue if you ask me 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a start-up check for minimum node and npm versions
4 participants