Add raw string literal highlighting for C# 11. #3906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue highlightjs#3868. This fails the tests as the Vala default.txt is recognised now as C#. However, Vala is very close in syntax to C#, and the default.txt also seems to be valid C# so not sure what to do about this.
joshgoebel
reviewed
Nov 8, 2023
joshgoebel
approved these changes
Mar 5, 2024
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +63 B View Changes
|
joshgoebel
reviewed
Mar 5, 2024
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +55 B View Changes
|
We are deemphasizing auto-detect - it was never great. Someone who cares about auto-detect can run the tool, but we will no longer fail the test suite based on any auto-detect issues.
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +58 B View Changes
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3868.
This fails the tests as the Vala default.txt is recognized now as C#. However, Vala is very close in syntax to C#, and the default.txt also seems to be valid C# so not sure what to do about this.
Changes
Added raw string regex to the csharp definition.
Checklist
CHANGES.md