Add better support for Python functions and props #4285
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang062
approved these changes
Jun 18, 2025
joshgoebel
reviewed
Jun 21, 2025
| }, | ||
| { | ||
| match: [ | ||
| /(?<!(?:import|from)\s+[\w.]*)/, // Negative lookbehind for import context |
There was a problem hiding this comment.
Do we have a test case for this? I'd like to see an example or two of what exactly we're avoiding here.
There was a problem hiding this comment.
Imagine the following line:
from base.derive import testI wouldn't want derive to be highlighted as a property. I added a test case for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve the syntax highlighting for Python (#4284)
It should now correctly highlight function calls, chained function calls, and properties.
Changes
Added three more regex rules to the Python rules.
Checklist
TBDCHANGES.mdTBD