This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Fix orders loading in 3DS account info formatter #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same collection to load 3 different set of orders is wrong because Magento always use the firs loaded collection. Indeed with the previous code Magento was sending the count of orders in the last 6 month even for the last year orders count and the last 24 hours orders count. Also note that the HiPay API limit the length of the last 24 hours orders count parameter to 3 characters length. So in a store where the same customer place more than 999 orders in 6 months he cannot pay anymore with the HiPay payment method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same collection to load 3 different set of orders is wrong because Magento always use the firs loaded collection. Indeed with the previous code Magento was sending the count of orders in the last 6 month even for the last year orders count and the last 24 hours orders count.
Also note that the HiPay API limit the length of the last 24 hours orders count parameter to 3 characters length. So in a store where the same customer place more than 999 orders in 6 months he cannot pay anymore with the HiPay payment method.