Skip to content

fix(cli): dirname #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2024
Merged

fix(cli): dirname #83

merged 3 commits into from
May 28, 2024

Conversation

hngngn
Copy link
Owner

@hngngn hngngn commented May 27, 2024

fix #82

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-solid ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:56am

Copy link
Contributor

github-actions bot commented May 27, 2024

A new prerelease is available for testing:

@hngngn
Copy link
Owner Author

hngngn commented May 27, 2024

@thednp can you test this?

@thednp
Copy link

thednp commented May 27, 2024

I tested npx [email protected] init same error.

@thednp
Copy link

thednp commented May 27, 2024

Are you sure import.meta.dirname is defined?

@hngngn
Copy link
Owner Author

hngngn commented May 27, 2024

well yes, i can log the dir and get the version number, but if you think this cause the problem, let me update it

@thednp
Copy link

thednp commented May 27, 2024

You need to use process.cwd() instead. But that triggers another error:

TypeError: (intermediate value).name(...).description(...).version is not a function at Mo (file:///............../node_modules/shadcn-solid/dist/index.js:267:4278)

@hngngn
Copy link
Owner Author

hngngn commented May 27, 2024

You need to use process.cwd() instead. But that triggers another error:

TypeError: (intermediate value).name(...).description(...).version is not a function at Mo (file:///............../node_modules/shadcn-solid/dist/index.js:267:4278)

no, is will read the project package.json

@hngngn
Copy link
Owner Author

hngngn commented May 27, 2024

@thednp check the new one

@thednp
Copy link

thednp commented May 27, 2024

This npx [email protected] ?

@hngngn
Copy link
Owner Author

hngngn commented May 27, 2024

yeah

@thednp
Copy link

thednp commented May 27, 2024

Seems to be working. Will let you know if any issue asap ok?

@thednp
Copy link

thednp commented May 27, 2024

I think the problem is fixed, safe to say it's ready for 0.7.3 I guess.

@hngngn hngngn changed the title fix(cli): args fix(cli): dirname May 28, 2024
@hngngn hngngn merged commit 27d669e into main May 28, 2024
2 of 3 checks passed
@thednp
Copy link

thednp commented May 28, 2024

@hngngn is this live now? Can I test 0.7.3?

@thednp
Copy link

thednp commented May 28, 2024

Please disregard the above, I tested with latest, all working flawless. Great work ;)

@hngngn hngngn deleted the fix/cli-args branch July 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: CLI won't work please check description
2 participants