Skip to content

docs: change installation command for first component #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024
Merged

docs: change installation command for first component #87

merged 3 commits into from
May 31, 2024

Conversation

rezajaber
Copy link
Contributor

In the Installation documentation, when the user should run the command to install the first component (button component), the command would fail, since it is referencing the shadcn-ui library instead of the shadcn-solid library.

In the Installation documentation, when the user should run the command to install the first component (button component), the command would fail, since it is referencing the shadcn-ui library instead of the shadcn-solid library.
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-solid ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 11:49am

@hngngn
Copy link
Owner

hngngn commented May 30, 2024

Thanks! I definitely need to be more thorough when checking pull requests to avoid these mistakes. I noticed the same issue in the SolidStart and Astro sections as well, could you update those too?

@hngngn hngngn added the documentation Improvements or additions to documentation label May 30, 2024
@rezajaber
Copy link
Contributor Author

Of course. I updated those as well!

@hngngn
Copy link
Owner

hngngn commented May 31, 2024

Thanks!

@hngngn hngngn merged commit b173f5a into hngngn:main May 31, 2024
3 checks passed
@hngngn hngngn mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants