Switch to builder pattern for rulesets and remove requiredLinearHistory for hc-spin and hc-launch

[matthme]

• Changes to using the Builder pattern for specifying ruleset options
• removes the requirement for a linear history for hc-launch and hc-spin

[github-actions]

🍹 preview on holochain/holochain/github

Pulumi report

View in Pulumi Cloud

  Previewing update (holochain/github)

View Live: https://app.pulumi.com/holochain/holochain/github/previews/9e2f2485-d2fc-482d-b4c8-124d7e4a7139

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github::holochain::pulumi:pulumi:Stack::holochain-github]
  ~ github:index/repositoryRuleset:RepositoryRuleset: (update)
      [id=3443294]
      [urn=urn:pulumi:github::holochain::github:index/repositoryRuleset:RepositoryRuleset::kitsune2-release]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_7_2::c531bc38-aeb8-4d92-97f3-a2282a25cd9c]
    - bypassActors: [
    -     [0]: {
            - actorId   : 5
            - actorType : "RepositoryRole"
            - bypassMode: "always"
          }
      ]
  ~ github:index/repositoryRuleset:RepositoryRuleset: (update)
      [id=4109810]
      [urn=urn:pulumi:github::holochain::github:index/repositoryRuleset:RepositoryRuleset::hc-launch-release]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_7_2::c531bc38-aeb8-4d92-97f3-a2282a25cd9c]
    ~ rules: {
        ~ requiredLinearHistory: true => false
      }
  ~ github:index/repositoryRuleset:RepositoryRuleset: (update)
      [id=4111947]
      [urn=urn:pulumi:github::holochain::github:index/repositoryRuleset:RepositoryRuleset::hc-spin-release]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_7_2::c531bc38-aeb8-4d92-97f3-a2282a25cd9c]
    ~ rules: {
        ~ requiredLinearHistory: true => false
      }
Resources:
  ~ 3 to update
  154 unchanged
  

[ThetaSinner]

Nice! That looks like it's extensible, maintainable and a nice cleanup you've done at the same time :)

[ThetaSinner]

Looks like it's removing a bypassActors on Kitsune2 repository rules, I'm not sure what that's about

[matthme]

Looks like it's removing a bypassActors on Kitsune2 repository rules, I'm not sure what that's about

I don't know it either. I don't have access to the kitsune2 repo settings to check what's set there currently. This removal was already shown by pulumi preview in the previous PR actually but it didn't seem to have any effect given that it's still showing up.

[matthme]

I was assuming maybe someone added themselves manually temporarily with special bypass priviledges and it would be okay to overwrite this with pulumi.