Skip to content

Add openLogs, exportLogs and factoryReset IPC calls #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 2, 2025

Conversation

matthme
Copy link
Collaborator

@matthme matthme commented Mar 18, 2025

Adds IPC calls to export/open logs and factory reset. This part of the backend part required for #21

@matthme matthme requested a review from a team March 18, 2025 10:53
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one CI question and a couple of renames requested

ThetaSinner
ThetaSinner previously approved these changes Mar 18, 2025
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Collaborator

@c12i c12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, left some comments

c12i
c12i previously approved these changes Mar 18, 2025
mattyg
mattyg previously approved these changes Mar 18, 2025
@matthme matthme dismissed stale reviews from mattyg and c12i via 0636439 April 2, 2025 13:40
@matthme matthme merged commit 41b2e3f into main Apr 2, 2025
@matthme matthme deleted the feat/export-open-logs branch April 2, 2025 14:25
matthme added a commit that referenced this pull request Apr 10, 2025
* fix release workflow

* switch to URL type for bootstrap and signaling url, address cleanup comments

* add holochain versions note to readme

* fix typo

* fix remaining moss reference, rename to holochainPath and lairPath

* add prettierrc.yaml and reformat all files

* fix bug of enabling app if memproof provisioning deferred

* add auto updater logic

* feat: Password logic (#22)

* implemented no-password and password-required options

* added password-optional logic

* fix bundling of html pages, add additional log line

* remove unused CSS

* moved styles to shared styles

* replace uuid with nanoid

* bump kangaroo to holochain 0.4.0 (#24)

* (feat) systray option (#25)

* bump kangaroo to holochain 0.4.0

* add optional systray logic

* revert accidentally changed package name

* Clarify icon not found warning (#26)

* clarify icon not found warning

* rephrasing

* remove redundant PNG

* remove duplicate whitespace

* change icon resolution requirement

* move to macos-13 for intel

* add config write step to yarn setup

* update ziptest url

* move setup step below ziptest fetching step

* bump to holochain 0.4.1

* added missing arch appendix in dmg name (#30)

* Fix: IPC handler timing (#31)

* move get-name-and-version handler before splashscreen creation

* move all handlers above splashscreen creation

* add comment why ipc handlers are registered before splash screen creation

* fixes for a macos code signed build (#37)

* change stable in readme

* fix if statement for windows code signing (#41)

* fix systray icon name (#42)

* Fix CI not working out of the box (#43)

* add option to specify .webhapp source url in config

* better langauge

* fix if condition

* fix bash script

* specify shell type

* moved setup to make sure npm packages are installed

* move name overwrite step

* fix hash assignment

* split windows and unix

* fix bracket and filename

* move webhapp fecthing to node script

* fix fetch:webhapp command

* fix webhapp node script

* fix wrong variable

* Update scripts/fetch-webhapp.js

Co-authored-by: mattyg <[email protected]>

* Update scripts/fetch-webhapp.js

Co-authored-by: mattyg <[email protected]>

* extract downloadFile into separate file to DRY up

---------

Co-authored-by: mattyg <[email protected]>

* Add openLogs, exportLogs and factoryReset IPC calls (#45)

* add openLogs, exportLogs and factoryReset IPC calls

* undo appId renaming

* more renaming undo

* add ci_pass test

* fix syntax

* fix syntax

* fix typo

* add needs field

* fix namings, more granular try/catch

* remove test.yaml again

* fix formatting

* move defaultSession cache deletion to separate function, add inline comment

* consolidate if statement and remove console logs

* change factory reset message

* bump to holochain 0.5.0-rc.0

* remove dummy name

* bump to 0.5.0-rc.1

* add changelog, update readme

---------

Co-authored-by: Joel Ulahanna <[email protected]>
Co-authored-by: mattyg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants