[FR] Add "minuterie" french translation for timer #3149
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @jbblanchet
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | ||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" |
There was a problem hiding this comment.
I considered adding this to the _common.yaml file, but wasn't sure if it was appropriate or not. Happy to make the change if needed.
There was a problem hiding this comment.
Let's avoid complexifying expansion rules. Even if what you did is more compact, it's more complex to read for contributors.
Golden rule for us is to keep the intent repo as legible as possible.
There was a problem hiding this comment.
Yeah, I might have gotten a little too cute there. I mainly did it because they share the same root, just with and without the prefix, but I see you point. I'll change them back.
FYI I didn't revert the full line, because I still needed the [e] to support the feminine minuterie, but I did revert the [sur]
There was a problem hiding this comment.
Thx a bunch for the contribution.
It looks good, I provided only one feedback (But copied it everywhere it's relevant)
Additional question: Are you located in Canada? We're looking for contributors in Canada because we're afraid to leave you folks behind because we do not know the french Canadian idioms
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | ||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" |
There was a problem hiding this comment.
Let's avoid complexifying expansion rules. Even if what you did is more compact, it's more complex to read for contributors.
Golden rule for us is to keep the intent repo as legible as possible.
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" |
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | ||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" |
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | ||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" |
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| @@ -54,7 +54,7 @@ intents: | |||
| # Minuteur d'une heure appelé Pizza | |||
| - "<minuteur> d'<timer_duration> <appele> {timer_name:name}" | |||
| expansion_rules: | |||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | |||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" | |||
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| @@ -101,7 +101,7 @@ intents: | |||
| # Mets un minuteur pour fermer la fenêtre dans 5 minutes | |||
| - "<mets> un <minuteur> pour {timer_name:name} dans <timer_duration>" | |||
| expansion_rules: | |||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | |||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" | |||
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| @@ -66,4 +66,4 @@ intents: | |||
| - "[Il reste] [encore] combien de temps avant (de |d'|<le>){timer_name:name}" | |||
| expansion_rules: | |||
| reste_t_il: "(reste-t-il)|(reste t il)" | |||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | |||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" | |||
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
| expansion_rules: | ||
| appele: "(appelé|nommé|surnommé|pour [<le>])" | ||
| appele: "(appelé[e]|[sur]nommé[e]|pour [<le>])" |
There was a problem hiding this comment.
Same comment as above, let's revert that particular change for legibility
I am indeed Québécois. I'd be happy to help with French Canadian specific expressions. I don't have a lot of spare time, but there doesn't seem to be that much intents being added. I'll try to find some time next week to review existing files to see if anything obvious. Thanks for your hard work, I`m very happy with my 2 new Voice Previews (even if they were tricky to get all the way up here 😄) |
Great ! Good job, Take care ! |
andreasbrett
changed the title
Adding "minuterie" option in addition to "minuteur" for timer operations to support French Canadian idioms.
See the Office québécois de la langue française definition of "minuterie" as a translation of "timer".
Happy to add more tests as needed. I tried to keep the PR short.