[FR] Add "ouvrir" and "fermer" to light intents #3153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbblanchet
commented
Apr 30, 2025
| augmente: "(augmente|augmenter|monte|monter)" | ||
| demarre: "(démarre|démarrer|lance|lancer)" | ||
| diminue: "(diminue|diminuer|baisse|baisser)" | ||
| eclaire: "(éclaire|éclairer|illumine|illuminer)" | ||
| eteins: "(éteint|eteint|éteins|eteins|éteindre|eteindre|désactive|désactiver|stoppe|stopper|arrête|arrêter|coupe|couper|<eteins_dirty>)" | ||
| eteins: "(éteint|eteint|éteins|eteins|éteindre|eteindre|désactive|désactiver|stoppe|stopper|arrête|arrêter|coupe|couper|ferme|fermer|<eteins_dirty>)" |
There was a problem hiding this comment.
I added ferme and fermer here instead of <ferme>, because the definition of <ferme> includes .
jbblanchet
commented
Apr 30, 2025
| @@ -493,12 +493,12 @@ expansion_rules: | |||
|
|
|||
| # Verbs | |||
| active: "(active|activer|joue|jouer|exécute|exécuter|démarre|démarrer|lance|lancer)" | |||
| allume: "(allume|allumer|active|activer|démarre|démarrer)" | |||
| allume: "(allume|allumer|active|activer|démarre|démarrer|ouvre|ouvrir)" | |||
There was a problem hiding this comment.
Same as ferme below, didn't want to include <monte> by transitivity.
andreasbrett
changed the title
|
@piitaya Let's keep an eye on collision with other intent when this drops out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "ouvrir" and "fermer" to turn lights on and off, to support French Canadians specificity.
Reference:
I didn't add any tests around setting light color. I wouldn't use "ouvrir" in that context.