Skip to content

iOS: Recents pointing to games in the app's Documents doesn't work properly #19211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrydgard opened this issue May 28, 2024 · 1 comment · Fixed by #19213
Closed

iOS: Recents pointing to games in the app's Documents doesn't work properly #19211

hrydgard opened this issue May 28, 2024 · 1 comment · Fixed by #19213

Comments

@hrydgard
Copy link
Owner

hrydgard commented May 28, 2024

This is simply because every time you launch, the app's Documents directory changes.

More info: https://stackoverflow.com/questions/47864143/document-directory-path-change-when-rebuild-application

Since we store the full absolute paths in Recents in the ini file, they won't match, so won't work.

For now, I think I'll try to detect if it's a Documents directory, and patch in the current Documents path.

I wonder if we have more cases of absolute filenames being stored like that... probably:

Features affected by this

  • Custom sound effects (RetroAchievements)
  • Recents
  • ...

Workarounds

For Recents, I'll just patch up any Documents paths on load, since it's easy to know what they should be.

For a more general solution, there seems to be something called Bookmarks: https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/FileSystemProgrammingGuide/AccessingFilesandDirectories/AccessingFilesandDirectories.html#//apple_ref/doc/uid/TP40010672-CH3

Should look into that, may be relevant for some cases.

@hrydgard hrydgard added this to the v1.18.0 milestone May 28, 2024
@Halo-Michael
Copy link
Contributor

Documents path won't change "every time" but do change when upgrade apps/etc. So basiclly should still do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants