New sceAtrac implementation: Testing and results

[hrydgard]

Now that #20098 is merged:

Get build 1433 or higher (the new sceAtrac implemenation is now on by default).

IMPORTANT: When testing, do not load from an old savestate, or a new savestate produced from an old savestate. Restart and load in-game, otherwise you won't get the new implementation!

Games confirmed fixed with the new impl

• FlatOut Head On: BGM skips after few seconds (Atrac3+) #6663
• Code Lyoko audio softlock (now: bad playback) #19994
• Audio problem (Kaitou Apricot) #15233
• Metal Slug XX Background music stops (Windows/macOS and libretro core) #19082
• FIFA 07 Game Crash #19177
• Passport to... London: Crash when playing phrase book in turbo mode #20025
• Castlevania Rondo of Blood original BGM choppy/intermittent. #5564
• Silverfall (ULES00808) soundtrack loop after a while #7708
• Mad Blocker Alpha - Revenge of the Fluzzles missing music #11899 (sceSas integration)
• Castlevania X Chronicles - unavoidable audio-related softlock bug in Rondo of Blood #11091
• avcodec_decode_audio4 in Grand Theft Auto: Chinatown Wars #18923
• Shrek smash and crash racing freezes, can be unfrozen by going into menu #10139
• SOCOM - U.S. Navy SEALS - Fireteam Bravo 3 atrac error #8179
• Wild ARM XF - Audio Bug #19236
• Coded Arms Contagion music stops playing in few seconds #13773
• MGSPW atrac(?) issue #12298
• Star Wars Battlefront: Elite Squadron can freeze PPSSPP at some point #8076
• Save State -> Load state changes in-game mechanics in "Jackass: the Game" #12083
• Driver '76 instability #16904
• LocoRoco 1 - crash with new sceatrac #20150

Things that need __sceSasConcatenateATRAC3 (should now work since #20156 )

Reports

• Sol Trigger the talking's volume are too low and missing voices if skipping cutscene #6511 (sceSas integration)
• L.A. Gridlock (Europe) missing ingame music #9066 (needs __sceSasConcatenateATRAC3, see Atrac3 new impl: Fix Sol Trigger #20128 )
• Angus Hates Aliens
  ...more

Games that need testing with the new impl

• Shin Ken to Mahou to Gakuen Mono Toki no Gakuen ,bgm has noise when the voice is output #8269
• Last Ranker needs testing due to comments in Attempt to provide an error in sceAtracGetInternalErrorInfo #7638

Hack PRs that have been closed

• Atrac: Revert part of #18414 #19015
• Add AtracDecodeDataRemainFrameHack #18396
• Attempt to provide an error in sceAtracGetInternalErrorInfo #7638

Compat.ini settings that can be removed

Actually, probably shouldn't - we'll still have to support the old sceAtrac implementation for savestate compatibility. But there's [AtracLoopHack].

[Mitra-88]

Tested this with ppsspp_win_v1.18.1-1386-g9190a83035 in metal slug XX and it seems like it has been fixed (I enabled experimental sceAtrac)

[sum2012]

Passport to London fix in v1.18.1-1386-g9190a83035 with experimental sceAtrac.
@hrydgard I cannot output "debug" log level now in normal release ?

[hrydgard]

Hm, you're supposed to, at least on desktop. On Android/iOS we cut debug logs in normal releases although I am considering reversing that, the performance change is small...

[sum2012]

Castlevania Rondo of Blood original BGM choppy/intermittent fix in v1.18.1-1386-g9190a83035 with experimental sceAtrac.
Silverfall (ULES00808) soundtrack loop after a while fix in v1.18.1-1386-g9190a83035 with experimental sceAtrac (No need loop hack)

[hrydgard]

NABN00B reports occasional crashes in GTA LCS.

Suspiciously, the BSS section of the sceAtrac module we load is tiny, not enough memory allocated for our contexts, so we might be stomping on some memory we shouldn't stomp on. Will need to fix.

[aeroallways2]

The Monster Hunter audio popping is not fixed by the experimental sceAtrac.

[hrydgard]

@aeroallways2 thanks for reporting. Will need to re-enable the ffmpeg path (for decoding single packets), and see if that helps - if so I might have screwed up some optimization of the decoder, or something..

[hrydgard]

@sum2012 #11091 is also fixed right?

[sum2012]

About "softlock " part , I don't mean it

[hrydgard]

I don't understand - it doesn't softlock anymore, right?

[redunka-zver]

Correct me if I'm wrong, but I think #11091 might actually be describing two unrelated bugs?
One is the aforementioned softlock that can occur in certain cutscenes and the Sound Test menu if the I/O Timing Method is set to "Fast", but is solvable by switching to "Simulate UMD Delays", and as far as I can tell this is still needed even with latest builds.
The other problem is songs abruptly fading out mid-playback until the next loop, which is the same as #5564 and is therefore definitely fixed by the new sceAtrac implementation.