Skip to content

Fix unreadable text in auth0 flow #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Conversation

nickdaria
Copy link
Contributor

Auth0 fields were showing black text against a dark text entry field. This overrides the class for those text entry foreground colors to white.

Before After
firefox_WfXH7Oy6Bf firefox_VFmXauxSLN

Auth0 fields were showing black text against a dark text entry field. Override text color to white.
@CLAassistant
Copy link

CLAassistant commented May 21, 2025

CLA assistant check
All committers have signed the CLA.

@pimterry
Copy link
Member

Excellent point! This must've been introduced recently due to some other style changes here.

I don't think this solution is quite complete though, since it will create the opposite problem for users using light-mode devices: the text will now be white against a white background.

The rest of the Auth0 UI here is all light-mode in both cases, so I think we should just make the input field light-mode (i.e. white background + dark text) in all cases. Does that make sense?

@nickdaria
Copy link
Contributor Author

nickdaria commented May 22, 2025

Excellent point! This must've been introduced recently due to some other style changes here.

I don't think this solution is quite complete though, since it will create the opposite problem for users using light-mode devices: the text will now be white against a white background.

The rest of the Auth0 UI here is all light-mode in both cases, so I think we should just make the input field light-mode (i.e. white background + dark text) in all cases. Does that make sense?

Sure, I'll push a commit that also updates the field background.

However, it was my understanding from brief testing that auth0 was not being affected by dark mode at all. At least, it didn't appear to show any results when toggling it systemwide with my Win11 machine.

Disregard. I encountered this issue while trying to get Pro, and upon further examination Pro is required for themes to work. I patched the account store to set light mode and validated the fix.

More complete fix to account for possible future issues with light mode
@nickdaria
Copy link
Contributor Author

Quick update:

For some reason, it appears light mode users were not affected by this change. Didn't dig into why. I have just gone ahead and forced the entry background to white and the text to black for a more complete fix.

Theme Before After
Light image image
Dark image image

@pimterry pimterry merged commit 9bb2e18 into httptoolkit:main May 23, 2025
7 checks passed
@pimterry
Copy link
Member

Great stuff, thanks @nickdaria!

In case you're not aware, HTTP Toolkit Pro is totally free for all contributors - I've just set up an account linked to the email from your git commits (me@nick***), just click 'Get Pro' then 'Log into existing account' to get started. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants