-
Notifications
You must be signed in to change notification settings - Fork 753
Removed unused checked exceptions #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2036 +/- ##
=========================================
Coverage 83.57% 83.57%
Complexity 2380 2380
=========================================
Files 235 235
Lines 7259 7259
Branches 382 382
=========================================
Hits 6067 6067
Misses 956 956
Partials 236 236 ☔ View full report in Codecov by Sentry. |
Removing exceptions... I thought this was a binary breaking change, but the API checks didn't fail for this change... I need to look at this further. |
Do you want me to try and split this between main and test? Also, I would think this would still be acceptable to do to non-public methods in main as users can't write code to link to them outside of reflection anyways. Finally, can you also provide more information on this project's stance on binary breaking change? Is this project fully against them, or this requires a special release?
|
Documentation:
This says it is not a breaking binary change. This section also hasn't changed up to JLS 22 ( https://docs.oracle.com/javase/specs/jls/se22/html/jls-13.html#jls-13.4.21 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating with latest changes. Assuming japicmp reports all clear, we'll take this.
Thanks!
Description
Removes exceptions not thrown by the methods.