Skip to content

Add config files for models #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 3, 2024
Merged

Add config files for models #131

merged 17 commits into from
Apr 3, 2024

Conversation

clefourrier
Copy link
Member

@clefourrier clefourrier commented Mar 27, 2024

Allows to provide models in 2 ways:

  • with the CLI, for very basic parameters, using --model_args only (will allow people to give a quick try to the lib, and the test suite to still work)
  • with individual model files.

Todos:

  • Update README
  • Test the 3 new config files (base/adapters/peft, TGI)

Fix #128

@clefourrier clefourrier requested a review from NathanHB March 28, 2024 08:48
NathanHB
NathanHB previously approved these changes Apr 2, 2024
@NathanHB NathanHB dismissed their stale review April 2, 2024 09:33

tests caught import issues I did not catch

@clefourrier
Copy link
Member Author

I think it comes from the merge I did this morning, will investigate, ty

@clefourrier
Copy link
Member Author

Should be good :D

@clefourrier clefourrier requested a review from NathanHB April 2, 2024 13:57
@clefourrier clefourrier merged commit efa1733 into main Apr 3, 2024
hynky1999 pushed a commit that referenced this pull request May 22, 2025
* added the different configs through yaml files
* edited task examples path

---------

Co-authored-by: Nathan Habib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use config files for the model parameters
2 participants