Bug fix extractive match #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lewtun
approved these changes
Feb 6, 2025
|
I didn't know you have approve right 😈 @lewtun |
Haha I don't but I want to go fast since I need this for huggingface/open-r1#196 :) Let's wait for @clefourrier @NathanHB to review before merging |
|
People with approve right are Nathan/Lewis/Hynel/Thom and myself iirc :) |
Haha, @clefourrier is too fast 🚀 ! |
|
It's not a long PR ^^ (thanks for the fix!) |
hynky1999
added a commit
that referenced
this pull request
May 22, 2025
* update extraction match to reflect newest math-verify * revert symbols, improve sets handling * rm todo * fmt + remove empty excepts + bump l2s * fmt * docstring * fixed boxed, bump broken latex2sympy * allow more separators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed I made a little opssie in boxed normalization which was causing quite big evaluation degradation. Secondly I noticed I forgot to remove one thing when porting from math-verify, this PR fixes it and from now on should be stable