Skip to content

Fix typo in vLLM MODEL_ARGS #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Maxwell-Jia
Copy link

Fixes a typo in the vLLM parameter name from gpu_memory_utilization (American spelling) to gpu_memory_utilisation (British spelling) to match vLLM's expected parameter name.

@lewtun
Copy link
Member

lewtun commented Feb 24, 2025

Hi @Maxwell-Jia the British spelling was originally a typo in lighteval which was fixed here: huggingface/lighteval#553

As a result, we need to retain the American spelling to compatibility

@lewtun lewtun closed this Feb 24, 2025
@Maxwell-Jia Maxwell-Jia deleted the typo branch February 26, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants