-
Notifications
You must be signed in to change notification settings - Fork 29.4k
[generate] model defaults being inherited only happens for newer models #36881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that sounds good!
a909bfe
to
423ec7e
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I personally think the processing logic can be further improved. For example, consider a user wanting to ensure greedy decoding by explicitly setting The core issue is that the current approach seems to primarily track deviations from the default, rather than explicit user intent. Perhaps the I'm not familiar enough with the codebase to propose a specific implementation, but hopefully, this description of the problem and the suggested conceptual approach is helpful. |
@MTDickens yes, this will be improved :) Our path forward will consist of having per-model |
What does this PR do?
#36684 activated the use of model-defaults (as opposed to global defaults) for unfilled parameters in the
generation_config
argument.It may lead to unexpected behavior on models that saw no changes, especially if the model has defined flags like
max_length
ormax_new_tokens
. This PR adds a flag to control this behavior, and makes it the default only for models saved from v4.50 (next release) onwards.