Skip to content

🔖 Fix: ensure user-provided labels are retained in self._signature_columns #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sxndqc
Copy link

@sxndqc sxndqc commented Jun 14, 2025

What does this PR do?

Fixes #
The _set_signature_columns_if_needed in sft_trainer.py overrides that of trainer.py in transformer, but it mistakenly ignores labels which makes it unable to train when the user selects skip_prepare_dataset=True in SFTConfig. Previous version (e.g 0.14.0) does not have an override version of _set_signature_columns_if_needed in sft_trainer.py.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

sxndqc and others added 3 commits June 14, 2025 16:21
@qgallouedec
Copy link
Member

I think you'll need to modify the collator as well

@qgallouedec
Copy link
Member

Now it should work as intended

@qgallouedec qgallouedec changed the title Fix: ensure user-provided labels are retained in self._signature_columns 🔖 Fix: ensure user-provided labels are retained in self._signature_columns Jun 16, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants