Skip to content

Bring better performances #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 30, 2019
Merged

Bring better performances #329

merged 10 commits into from
May 30, 2019

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented May 30, 2019

  • Remove the deprecated Humbug\PhpScoper\Console\Configuration and make the parent Humbug\PhpScoper\Configuration final
  • Replace usage of uniqid by bin2hex(random_bytes())
  • Move namespace related PhpParser classes under PhpParser\NamespaceStmt
  • Similar change as namespaces for use statements
  • Introduce NamespaceManipulator and UseStmtManipulator in order to add the original name of the statement as an attribute and leverage this instead of (deep) cloning the whole node; this avoid to have to rely on heavy serialize/unserialize calls
  • Heavily simplify the Reflector class by leveraging the phpstorm stub maps (which is generated by BetterReflection at the moment) instead of requiring to retrieve the whole reflection class for a given symbol

Closes #321

@theofidry theofidry merged commit 1275a48 into humbug:master May 30, 2019
@theofidry theofidry deleted the bugfix/speed branch May 31, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize use & namespaces lookups
1 participant