Update Reflector to account for missing symbols #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The PHAR is missing for the 0.12.1 release, though. |
|
Fixed with 0.12.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is unlikely that JetBrains' response time on its stubs library is satisfying in the short-term at least, I think it makes sense to take advantage of the current
Reflectordesign to patch the stubs here in PHP-Scoper.This PR introduce back a way to enrich the symbols taken from the stub map and add the following:
uvextensionkrakjoe/parallelextensionkrakjoe/pcovextensioncryptoextensionsapi_windows_vt100_support()function/cc @sebastianbergmann this should make things easier for PHPUnit :)