Skip to content

Improve file whitelist performances #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 31, 2021
Merged

Improve file whitelist performances #445

merged 7 commits into from
May 31, 2021

Conversation

theofidry
Copy link
Member

Extracted from #410

@theofidry
Copy link
Member Author

theofidry commented Nov 29, 2020 •
edited
Loading

/cc @Konamiman

I've been tinkering with a few things in PHP-Scoper & Box. Although the path to get there was very different, in the end I think this is pretty much what you have in #410. A few differences

  • This is strictly about the file whitelisting performance (in your PR there is a few other changes which would be nice to have as well but in a dedicated PR)
  • It does not remove the FileWhitelistScoper: it is used in Box
  • It does not integrate your simplification for file/file-contents which may be worth doing

@theofidry theofidry merged commit e43899e into humbug:master May 31, 2021
@theofidry theofidry deleted the feature/file-whitelist branch May 31, 2021 07:49
@theofidry theofidry mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry