Skip to content

Validate the prefix in the Configuration instead of the command #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021

Conversation

theofidry
Copy link
Member

BC break: the prefix can no longer end with back-slashes

@theofidry theofidry enabled auto-merge (squash) May 18, 2021 21:04
@theofidry theofidry merged commit 1655209 into humbug:master May 18, 2021
@marekdedic
Copy link
Contributor

Hi,
I've been messing a little bit with php-scoper again and this caught me by surprise - not only is it that the prefix cannot end with backslashes, it cannot contain backslashes... I, for example, am using the prefix Sgdg\Vendor - now this fails...

@theofidry theofidry deleted the feature/consolidate-prefix branch May 20, 2021 08:24
@theofidry
Copy link
Member Author

I see, I suppose it's fine if it contain backslashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants