Skip to content

fix(connector-besu): toBuffer only supports 0x-prefixed hex was given: 3000000 #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petermetz opened this issue Oct 13, 2023 · 0 comments · Fixed by #2831
Closed

fix(connector-besu): toBuffer only supports 0x-prefixed hex was given: 3000000 #2791

petermetz opened this issue Oct 13, 2023 · 0 comments · Fixed by #2831
Assignees
Labels
Besu bug Something isn't working good-first-issue Good for newcomers good-first-issue-400-expert P2 Priority 2: High Security Related to existing or potential security vulnerabilities
Milestone

Comments

@petermetz
Copy link
Contributor

Description

The ./packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-web3-eea.test.ts
besu test case is failing consistently.
It might be because of a recent dependency upgrade.

Steps to Reproduce

$ yarn ts-node ./packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-web3-eea.test.ts 


TAP version 13
# Executes private transactions on Hyperledger Besu
[2023-10-13T05:49:59.767Z] DEBUG (BesuMpTestLedger): Instantiated BesuMpTestLedger OK
[2023-10-13T05:50:00.412Z] DEBUG (containers#tryPullImage()): Started ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2023-08-08-pr-2596 pull progress stream OK
[2023-10-13T05:50:00.417Z] DEBUG (containers#tryPullImage()): "Pulling from hyperledger/cactus-besu-all-in-one-multi-party"
[2023-10-13T05:50:00.422Z] DEBUG (containers#tryPullImage()): Finished ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2023-08-08-pr-2596 pull completely OK
[2023-10-13T05:50:00.423Z] DEBUG (BesuMpTestLedger): Starting ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2023-08-08-pr-2596 with options:  {
  HostConfig: {
    AutoRemove: true,
    Env: [],
    Privileged: true,
    PublishAllPorts: true
  }
}
[2023-10-13T05:50:01.288Z] DEBUG (BesuMpTestLedger): Started ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2023-08-08-pr-2596 successfully. ID=0350cf884c0c5b010a6145e9835a946e0b94cf05c0d3c296f341f9863b552b6c
[2023-10-13T05:50:01.418Z] DEBUG (containers#tryPullImage()): "Status: Image is up to date for ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2023-08-08-pr-2596"

# chainIdMember1=1337
# chainIdMember2=1337
# chainIdMember3=1337
ok 1 web3QuorumMember1 truthy OK
ok 2 web3QuorumMember2 truthy OK
ok 3 web3QuorumMember3 truthy OK
not ok 4 Error: Cannot convert string to buffer. toBuffer only supports 0x-prefixed hex strings and this string was given: 3000000
  ---
    operator: error
    at: bound call (/*****/cacti/node_modules/tape-promise/node_modules/onetime/index.js:30:12)
    stack: |-
      Error: Cannot convert string to buffer. toBuffer only supports 0x-prefixed hex strings and this string was given: 3000000
          at toBuffer (/*****/cacti/packages/cactus-plugin-ledger-connector-besu/node_modules/web3js-quorum/src/util/custom-ethjs-util.js:68:15)
          at PrivateTransaction.setter [as gasLimit] (/*****/cacti/packages/cactus-plugin-ledger-connector-besu/node_modules/web3js-quorum/src/util/custom-ethjs-util.js:144:13)
          at genericSendRawTransaction (/*****/cacti/packages/cactus-plugin-ledger-connector-besu/node_modules/web3js-quorum/src/priv.js:339:17)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at async /*****/cacti/packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-web3-eea.test.ts:103:26
  ...

1..4
# tests 4
# pass  3
# fail  1
@petermetz petermetz added Besu bug Something isn't working good-first-issue Good for newcomers good-first-issue-400-expert P2 Priority 2: High Security Related to existing or potential security vulnerabilities labels Oct 13, 2023
@petermetz petermetz added this to the v2.0.0 milestone Oct 13, 2023
@jagpreetsinghsasan jagpreetsinghsasan moved this from Todo to In Progress in Cacti_Scrum_Project_v2_Release Oct 20, 2023
ruzell22 added a commit to ruzell22/cactus that referenced this issue Oct 25, 2023
ruzell22 added a commit to ruzell22/cactus that referenced this issue Oct 25, 2023
ruzell22 added a commit to ruzell22/cactus that referenced this issue Oct 26, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
30000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Oct 26, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
@jagpreetsinghsasan jagpreetsinghsasan moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Oct 26, 2023
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 7, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 7, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 7, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 7, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 7, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
petermetz pushed a commit to ruzell22/cactus that referenced this issue Dec 8, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
petermetz pushed a commit that referenced this issue Dec 10, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: #2791

Signed-off-by: ruzell22 <[email protected]>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Dec 10, 2023
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Besu bug Something isn't working good-first-issue Good for newcomers good-first-issue-400-expert P2 Priority 2: High Security Related to existing or potential security vulnerabilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants