Skip to content

test(connector-corda): fix flaky corda-v5-flow.test.ts #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrianbatuto opened this issue Jun 4, 2024 · 0 comments · Fixed by #3241
Closed

test(connector-corda): fix flaky corda-v5-flow.test.ts #3293

adrianbatuto opened this issue Jun 4, 2024 · 0 comments · Fixed by #3241
Assignees
@adrianbatuto
Labels
bug Something isn't working Corda good-first-issue-400-expert P1 Priority 1: Highest

Comments

@adrianbatuto
Copy link
Contributor

adrianbatuto commented Jun 4, 2024 •
edited by jagpreetsinghsasan
Loading

Describe the bug

packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-x/corda-v5-flow.test.ts from the PR #3241 is flaky

To Reproduce

Comment out the timeout added to the test as a temporary fix for this issue and run the test

Expected behavior

Test is consistent/stable and shouldnt contain manual timeouts (as they are very much dependent on system specifications and other factors, and thus vary inconsistently)
@adrianbatuto adrianbatuto added the bug Something isn't working label Jun 4, 2024
@jagpreetsinghsasan jagpreetsinghsasan added Corda P1 Priority 1: Highest P2 Priority 2: High good-first-issue-400-expert and removed P2 Priority 2: High labels Jun 4, 2024
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jun 14, 2024
@adrianbatuto
test(connector-corda): fix flaky corda-v5-flow.test.ts
3e1660d 
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
@adrianbatuto adrianbatuto mentioned this issue Jun 14, 2024
Closed
5 tasks
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jun 21, 2024
@adrianbatuto
test(connector-corda): fix flaky corda-v5-flow.test.ts
bf0f92a 
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
@ruzell22 ruzell22 moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Jun 21, 2024
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 3, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
2e544cd 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@adrianbatuto adrianbatuto mentioned this issue Jul 3, 2024
Merged
5 tasks
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 3, 2024
@adrianbatuto
test(connector-corda): fix flaky corda-v5-flow.test.ts
de34c90 
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 3, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
f40d5c3 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 4, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
a77cd08 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 4, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
8f07fb8 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 10, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
a1761a9 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 10, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
bc9818e 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 12, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
445e0fb 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 19, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
a1fe136 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 23, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
5c1abee 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 23, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
15069c2 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 23, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
2cf96c6 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 23, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
9014731 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Jul 23, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
ebdb9ee 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 5, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
a93e56c 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 12, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
56fa46b 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 12, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
a0397ad 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 12, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
c960449 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 15, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
3cd5b23 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 15, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
5e7ff7b 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 19, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
755e177 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 19, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
35e3ff3 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to johnhomantaring/cactus that referenced this issue Aug 19, 2024
@adrianbatuto
feat(corda): support 5.1 via TS/HTTP (no JVM)
53d1b9a 
Fixes hyperledger-cacti#2978
Fixes hyperledger-cacti#3293

Signed-off-by: adrianbatuto <[email protected]>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianbatuto adrianbatuto

Labels
bug Something isn't working Corda good-first-issue-400-expert P1 Priority 1: Highest
Projects
None yet
Milestone
No milestone
2 participants
@jagpreetsinghsasan @adrianbatuto