-
Notifications
You must be signed in to change notification settings - Fork 299
docs: update README #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README #311
Conversation
We can add an updated version of the architecture, and forward readers to the whitepaper, as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RafaelAPB Would be nice to have a more specific commit message. |
I've chosen that specific message because the commit also removes parts of it. Would it still be reasonable to only refer the build instructions? |
Tough question. It definitely makes sense IMO to not just say |
Makes sense. Let's see first what the other reviewers think. |
Sorry, I mistook to choose review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have strengthened your proposal as the commit below. The reason is written in the header of the commit below. Do you have any comments?
3bfab32
I agree, @takeutak ! Thanks! |
CI is failing because of an unrelated problem: #319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI resolution
Signed-off-by: Rafael Belchior <[email protected]>
3bfab32
to
ec354ad
Compare
Done @petermetz , thanks! |
Excuse me, it look like that the current README ignores my suggestion (due to the mistake on solving CI falling?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said the above, the current status ignores my above commit. Then I canceled my LGTM at once.
Signed-off-by: Takuma TAKEUCHI <[email protected]>
I pushed the following commit, which content is the same as the above my commit. Now I approved this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current README presents potentially outdated information that holds details that are better suitable for the whitepaper. It lacks instructions on how to build and run the project, which can frustrate newcomers.
I would propose us to simplify the README of the project, and as the example section matures, provide a practical example.