-
Notifications
You must be signed in to change notification settings - Fork 304
test(weaver/interoperation-node-sdk): fix broken nyc tests #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@takeutak @petermetz kindly review my PR |
Also @hollermay can you make the PR and the commit title same as issue title. That's a guideline in Cacti. This makes it easy to track PRs and its corresponding issues. |
I have made the changes to the title. Kindly check. |
Thanks, please make the commit title same too. |
@hollermay You will need to sign the commit, that's why DCO check is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, all tests are passing hence approving.
Please address the comments above before merging.
I've addressed all the comments and did the changes as per your requirements. With the valid signoffs the PR is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@sandeepnRES any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hollermay It seems you created a merge commit in this PR, when updating with main.
Use only rebase and merge/update
whenever updating your branch.
Can you fix this? make sure no merge commits are there, and no commits from others should show. The PR should have only one commit which is yours.
Let me know if you need help regarding this.
One way is to delete the merge commit, push the changes, and then using this github interface use update with rebase
option that you can see in this PR window below.
On it! |
Adds [email protected] as a direct dependency to the Fabric interoperation node SDK to resolve ESM compatibility issues that were causing test failures. This ensures proper module resolution when running tests and maintains compatibility with the SDK's existing dependencies. Signed-off-by: hollermay <[email protected]>
@sandeepnRES I have done the changes as required. |
@sandeepnRES kindly check |
This pull request resolves #3305
Adds [email protected] as a direct dependency to the Fabric interoperation node SDK to resolve ESM compatibility issues that were causing test failures. This ensures proper module resolution when running tests and maintains compatibility with the SDK's existing dependencies.
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.