fix: Return current timestamp when nonce lags #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `next_nonce()` always returns a unique nonce, by storing the current timestamp in a static variable and incrementing it before returning. However, this variable can lag during times of inactivity. Though there is a check that handles it by updating it, it ends with returning the old nonce, which fails the current call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
next_nonce()always returns a unique nonce, by storing the current timestamp in a static variable and incrementing it before returning. However, this variable can lag during times of inactivity. Though there is a check that handles it by updating it with the current timestamp, it ends with returning the old nonce, which fails the current call.This fix makes sure that the current timestamp is returned when this check gets triggered.