Skip to content

Fix keyboard navigation for modals #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julianguyen opened this issue Oct 1, 2022 · 0 comments
Closed

Fix keyboard navigation for modals #2118

julianguyen opened this issue Oct 1, 2022 · 0 comments

Comments

@julianguyen
Copy link
Member

julianguyen commented Oct 1, 2022

Description

When using keyboard navigation to TAB through a page, modals should not open up unless the ENTER key is hit. Currently, this is not happening when a user hits TAB on a button that triggers a modal, the modal opens up.

Fixing this issue should be done in the React component for Modal.

Reproduction Steps

Current Behaviour

  1. TAB through the entire page until you hit a button that opens a modal
  2. After you are focused on the button, hit TAB again
  3. The modal will open

Expected Behaviour

  1. TAB through the entire page until you hit a button that opens a modal
  2. After you are focused on the button, hit TAB again
  3. The focus should be on the next link or button on the page
  4. Refresh the page and TAB` through the entire page until you hit a button that opens a modal
  5. Hit ENTER and the modal should open up

Contributor Blurb Modals

These appear on the non-signed in Homepage and the About page (non-signed in and signed in).

Sep-30-2022 22-26-53

Notification Modal in the Dashboard Navigation

This appears on every signed-in page.

Sep-30-2022 22-23-55


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants