[FIX] Keyboard navigation for modals #2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
maniSHarma7575
force-pushed
the
2118-fix-keyboard-navigation-for-modals
branch
2 times, most recently
from
c7819dc to
9a90ff2
Compare
julianguyen
requested changes
Oct 2, 2022
maniSHarma7575
force-pushed
the
2118-fix-keyboard-navigation-for-modals
branch
4 times, most recently
from
5a6c9dd to
e0d2c72
Compare
julianguyen
requested changes
Oct 2, 2022
maniSHarma7575
force-pushed
the
2118-fix-keyboard-navigation-for-modals
branch
from
e0d2c72 to
4259444
Compare
|
@julianguyen Thanks for the feedback!, PR is ready for review. |
maniSHarma7575
force-pushed
the
2118-fix-keyboard-navigation-for-modals
branch
from
4259444 to
45a6d08
Compare
julianguyen
approved these changes
Oct 3, 2022
|
Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page. |
Thanks @julianguyen You are doing fantastic work, Pleasure 🙏 to be part of this initiative. Keep doing the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handleKeyPressfunction. Earlier on every key press it was calling thetoggleOpenmethod.Now only when it's enter key then only the
toggleOpenwill be called.Corresponding Issue
#2118
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!