Improve/add appropriate message during workspace setup step #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohandaxini
changed the title
julianguyen
requested changes
Oct 2, 2022
rohandaxini
changed the title
|
Hi @julianguyen Could you please review this PR and merge if it looks good? |
julianguyen
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when we run
bin/rake setup_workspacestep, it's not clear (i.e. does not indicate) whether the setup process is completed properly or not. This change adds an appropriate message with a check whether the setup process was successful or not.Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!