Support loading assets from Package. #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@McProb Thanks for submitting! I agree it would be best to wait until iOS 14 is finalized before merging this, I'll leave this up until then. |
|
@McProb any idea if this behavior remained consistent in the iOS 14 GM? if so I can merge this |
|
I'm not certain that this will stay working. I'll take a look in the next day or two and see if I can get the official way of doing it working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may or may not want to incorporate this pull request at this time. I won't be surprised if Xcode changes how assets in packages work. But this may be a good reference for others who want to load assets from a SPM bundle at this time. Once we get into the later betas for Xcode, perhaps we'll consider this pull request.